Binarizer performance improvements #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danimoh
force-pushed
the
daniel/binarizer-performance-improvements
branch
3 times, most recently
from
4a4f2a9
to
fddc609
Compare
|
I just noticed, that a |
danimoh
force-pushed
the
daniel/binarizer-performance-improvements
branch
from
fddc609
to
25e98b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Cosmo.
I noticed that in the binarizer new buffers are assigned for the grayscale image and binary image(s).
However, these buffers can be assigned within the rgba image buffer, as this data is not needed anymore after conversion to grayscale / binarization.
This saves allocation and garbage collection of up to 3 * pixelCount + blackPointsCount bytes.
According to my tests, this makes the code 20%-30% faster.
(Sorry for the force-pushs. I couldn't run the tests locally and therefore had to rely on travis for testing.)