Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Add Encryption #48

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Encryption #48

wants to merge 4 commits into from

Conversation

danielgek
Copy link

@danielgek danielgek commented Jan 12, 2017

What this commit changes?

  • Added optional string key to constructor, if key is defined the plugin will try to open/create an encrypted database
  • added encryption implementation
  • added method to close database
  • added another page to ng-demo for testing the encryption
  • removed Couchbase Library and readded with cocoapods

Todo list

  • cleanup
  • add more testcases to ng-demo

@nraboy i don't have time right now for the todos list, but i can do it later!! if you need something else just say it ;)

@nraboy
Copy link
Contributor

nraboy commented Jan 12, 2017

Can you pull from the upstream and do a proper merge? Seems like your repository might have been out of date.

Other than that, it looks great. I am going to test it tomorrow :-)

@danielgek
Copy link
Author

@nraboy Done ;)

Copy link

@bot2600 bot2600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done +1 to getting this merged so I can use it!

@bot2600
Copy link

bot2600 commented Mar 3, 2017

@nraboy what is the status of this? I'm really itching to encrypt the magic :)

@nraboy
Copy link
Contributor

nraboy commented Mar 3, 2017

@danielgek,

Sorry I've taken so long on this.

After reviewing the ng-demo that you've provided, I noticed a lot of the demo had been commented out. I feel it is necessary to leave that information uncommented.

Can you rollback the following files (use what's in the master):

  • ng-demo/[all files and folders]
  • package.json

Your other changes look good. Just want to remove the conflicts. We can clean up the demos later.

@bot2600
Copy link

bot2600 commented Mar 3, 2017

@danielgek let me know if you are too busy and I should be able to find time to help

@danielgek
Copy link
Author

@nraboy @bot2600 after more test on this, it still not working for iOS, i don't have much time now to get back on this, in mean time you can adopt this approach

if you have any doubt about this, feel free to ask i still remember a few things about this

@hypery2k
Copy link
Contributor

@danielgek So it isn't working at all?

@danielgek
Copy link
Author

@hypery2k for ios it's not

@aboganas
Copy link
Contributor

any update on this? can at least for now have this for Android since its working.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants