Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testing framework #310

Merged
merged 1 commit into from
May 23, 2024
Merged

Improve testing framework #310

merged 1 commit into from
May 23, 2024

Conversation

Westwooo
Copy link
Contributor

No description provided.

chvck
chvck reviewed Apr 30, 2024
View reviewed changes
src/cli/tests/utils.rs Outdated Show resolved Hide resolved
chvck
chvck reviewed May 1, 2024
View reviewed changes
tests/doc_get.rs Outdated Show resolved Hide resolved
@chvck
Copy link
Contributor

chvck commented May 1, 2024

It might be worth having a google to see how others have approach the "setup suite" issue. When I looked it seems like there are crates out there that can help a bit.

@chvck
Copy link
Contributor

chvck commented May 1, 2024

FWIW I think integration tests should also remain in the tests directory, and unit tests alongside the code. Another thing to consider is whether we can add some unit tests for trickier cases to repro, see the mocking approach in couchbaselabs/couchbase-rs#155. Out of scope for this PR though.

@Westwooo Westwooo force-pushed the Improve_testing_framework branch from 38d54fa to a77c441 Compare May 1, 2024 11:39
@Westwooo
Copy link
Contributor Author

Westwooo commented May 1, 2024

FWIW I think integration tests should also remain in the tests directory, and unit tests alongside the code. Another thing to consider is whether we can add some unit tests for trickier cases to repro, see the mocking approach in couchbaselabs/couchbase-rs#155. Out of scope for this PR though.

I agree, have moved everything back.

@Westwooo Westwooo changed the title Move tests into folder with code they are testing Improve testing framework May 1, 2024
@Westwooo Westwooo force-pushed the Improve_testing_framework branch 23 times, most recently from 2f14b16 to f177ec9 Compare May 14, 2024 14:33
chvck
chvck reviewed May 14, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Westwooo Westwooo force-pushed the Improve_testing_framework branch 3 times, most recently from c3c1246 to 56caf62 Compare May 15, 2024 08:28
chvck
chvck reviewed May 15, 2024
View reviewed changes
tests/query_indexes.rs Outdated Show resolved Hide resolved
@Westwooo Westwooo force-pushed the Improve_testing_framework branch 9 times, most recently from d346c36 to 516a5ba Compare May 15, 2024 11:01
@Westwooo Westwooo requested a review from chvck May 15, 2024 11:09
@Westwooo Westwooo force-pushed the Improve_testing_framework branch 3 times, most recently from 153d43f to 2004bc0 Compare May 15, 2024 14:17
chvck
chvck reviewed May 15, 2024
View reviewed changes
tests/common/playground.rs Outdated Show resolved Hide resolved
@Westwooo Westwooo requested a review from chvck May 16, 2024 13:00
@Westwooo Westwooo merged commit 98d6ef5 into main May 23, 2024
8 checks passed
@Westwooo Westwooo deleted the Improve_testing_framework branch May 23, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvck chvck chvck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Westwooo @chvck