add python formatting and checking with ruff #6772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove unused modules / variables - fix tests to start with test_* so that they run, change tests so that they pass - remove duplicate definitions - use `x not in y` instead of `not x in y`
bbrks
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows use of common editors that format with black or ruff. Adds CI to make sure it takes.
Otherwise, I kept accidentally autoformatting files when I did a fix and I had to revert to use an editor without automatic formatting turned on.
The first commit is github actions changes, the second commit just automatic formatting, and the third commit 3142d31 is the manual changes I made. When reviewing, just look at {{.github}} folder and the third commit.