Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite sgcollect in go #5783

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

markspolakovs
Copy link
Contributor

@markspolakovs markspolakovs commented Sep 23, 2022

Rewrite sgcollect in go.

  • Will almost certainly break the build, as it'll expect Python sgcollect to be present.
  • The sgcollect code intentionally doesn't import modules from the existing SG packages (eg. utilities in base or type definitions from rest). This is to keep the binary size down, as all those packages' dependencies will be imported even if they're not used.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant