Skip to content

Commit

Permalink
GHA: ditch the s390x bloat - never succeeds
Browse files Browse the repository at this point in the history
Actually the s390x bloat never succeed and prevents a priori
all PRs from being accepted. Never heard, that anybody is
running coturn on a non-{Linux,Solaris,BSD} platform.
Having tests for all possible OS/arches is one thing, actually
testing against all is a completely different thing - not a
green at all and wastes a lot of resources. So IMHO the test
matrix should be revised to reflect, what is really needed.
  • Loading branch information
Jens Elkner committed Dec 8, 2023
1 parent 1776f3c commit 26c7a72
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
- arm64v8
- i386
- ppc64le
- s390x
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -94,7 +93,6 @@ jobs:
- arm64v8
- i386
- ppc64le
- s390x
runs-on: ${{ (matrix.dist == 'alpine' && matrix.arch == 's390x' && 'macos')
|| 'ubuntu' }}-latest
steps:
Expand Down Expand Up @@ -203,8 +201,7 @@ jobs:
arm32v7 \
arm64v8 \
i386 \
ppc64le \
s390x
ppc64le
do
make docker.untar \
from-file=.cache/${{ matrix.dist }}-$arch-${{ github.run_number }}/image.tar
Expand All @@ -225,8 +222,7 @@ jobs:
${{ steps.docker.outputs.tag }}-arm32v7
${{ steps.docker.outputs.tag }}-arm64v8
${{ steps.docker.outputs.tag }}-i386
${{ steps.docker.outputs.tag }}-ppc64le
${{ steps.docker.outputs.tag }}-s390x'
${{ steps.docker.outputs.tag }}-ppc64le'
tags=${{ (!startsWith(github.ref, 'refs/tags/')
&& steps.docker.outputs.tag)
|| '' }}
Expand Down

0 comments on commit 26c7a72

Please sign in to comment.