Pg_query integration #691
Open
Pg_query integration #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lagovas
reviewed
Nov 16, 2023
# Conflicts: # cmd/acra-server/common/config.go # cmd/redis.go # encryptor/base/config_loader/config_loader.go # encryptor/base/config_loader/consul/storage.go # encryptor/base/config_loader/filesystem/storage.go
Fixed failing tests
Lagovas
reviewed
Dec 4, 2023
Lagovas
reviewed
Dec 7, 2023
Lagovas
reviewed
Dec 12, 2023
| func (filter *SearchableQueryFilter) ChangeSearchableOperator(expr *pg_query.A_Expr) { | ||
| switch expr.Name[0].GetString_().GetSval() { | ||
| // sqlparser.NullSafeEqualStr, sqlparser.LikeStr, sqlparser.ILikeStr | ||
| case "=": |
There was a problem hiding this comment.
we handle here only = operator? and stopped handling !=/<>? and ignore like/ilike?
There was a problem hiding this comment.
Nice you found it. It can affect the EE part.
|
|
||
| if expr.Rexpr.GetAConst() != nil || expr.Rexpr.GetParamRef() != nil || expr.Rexpr.GetTypeCast() != nil { | ||
| if len(expr.Name) == 1 { | ||
| if val := expr.Name[0].GetString_(); val != nil && (val.GetSval() == "=" || val.GetSval() == "<>") { |
There was a problem hiding this comment.
should we handle !=? as I remember, postgres accepts it
There was a problem hiding this comment.
Yes, it accepts it but the parser represents it as <>. != is an alias of <>
https://www.postgresql.org/docs/current/functions-comparison.html
There was a problem hiding this comment.
I remember that for pgsql it's the same but not sure should we handle it explicitly here or parser converts != -> <>
There was a problem hiding this comment.
Yes, the parser converts it to <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration of pg_query PostgreSQL parser into QueryDataEncryptor component. Split
encryptorinto PostgreSQL and MySQL componentsChecklist
with new changes