Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix garbled encoding issue when build fails on non-Latin Windows systems #515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fanyang89
Copy link

The default encoding in Go is UTF-8. However, when cmd.exe is run on non-Latin Windows systems, it may use an encoding other than UTF-8, which can lead to garbled text.

This patch addresses the issue by running chcp to set the code page to UTF-8 before executing commands.

Reproduce(run on a non-latin Windows):

air init

Then modify the .air.toml:

  bin = "tmp\\main.exe"
  cmd = "go build -o ./tmp/main.exe ."

To(leave tmp_dir alone)

  bin = "bin\\main.exe"
  cmd = "go build -o ./bin/main.exe ."

Before this patch:

image

After:

image

The default encoding in Go is UTF-8. However, when `cmd.exe` is run on
non-Latin Windows systems, it may use an encoding other than UTF-8,
which can lead to garbled text.

This patch addresses the issue by running `chcp` to set the code page to
UTF-8 before executing commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant