Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global default config #489

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sarjann
Copy link

@sarjann sarjann commented Oct 20, 2023

Added the ability to specify your own default config.
Think it's a nice convenience, in my case, I wanted to change the tmp directory to a hidden directory for example
and it's a bit annoying to have to update the air.toml in each project.

@sarjann sarjann force-pushed the feature/global_default_config branch 2 times, most recently from 6babfe9 to 129ab1b Compare October 20, 2023 22:24
@xiantang
Copy link
Collaborator

seems good but I i want to know is this the common case ?

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b8f3808) 68.70% compared to head (129ab1b) 68.94%.
Report is 5 commits behind head on master.

❗ Current head 129ab1b differs from pull request most recent head d36e7d2. Consider uploading reports for the commit d36e7d2 to get more accurate results

Files Patch % Lines
runner/config.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
+ Coverage   68.70%   68.94%   +0.23%     
==========================================
  Files           9        9              
  Lines        1061     1069       +8     
==========================================
+ Hits          729      737       +8     
  Misses        252      252              
  Partials       80       80              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarjann
Copy link
Author

sarjann commented Oct 23, 2023

seems good but I i want to know is this the common case ?

Hard to say without asking other people, but this doesn't break backwards compatibility and I think it's a nice feature. Also I think a lot of people will probably have their own defaults that they like.

@sarjann
Copy link
Author

sarjann commented Nov 12, 2023

Not sure if there are any additional changes you want to make or if you're happy for this to be merged. @xiantang
If you're fine with the changes I can add some tests (lines aren't currently covered), I'm having some trouble running tests locally but can figure it out.

@sarjann sarjann force-pushed the feature/global_default_config branch from 129ab1b to d36e7d2 Compare December 3, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants