feat: Make include_file overrule include_ext, fixes: #350, base_on: #358 #416
+62
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
approved these changes
Apr 21, 2023
|
Please add "Fixes: #350" to your comment. |
zhb127
changed the title
OK |
|
Bump, would love to see this merged. |
|
Just to notify, I personally want to see this merged |
|
Bump - would love to see this merged as well, seems it's been hanging for a while |
flada-auxv
reviewed
Feb 1, 2024
zhb127
force-pushed
the
feat/make_include_file_overrule_include_ext
branch
from
88b8e9c
to
957cbd9
Compare
|
You should also include this change to actually test the changed functionality: |
thx, The test code has been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #350
Base on: #358
I don't know, why marked #358 PR as draft?
Just fix code by #358 PR author's comments. then create new PR.