Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cef 109 #324

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Cef 109 #324

wants to merge 10 commits into from

Conversation

Schneegans
Copy link
Member

No description provided.

@Schneegans Schneegans added this to the Version 1.8.0 milestone Jan 27, 2023
@coveralls
Copy link

coveralls commented Feb 8, 2023

Pull Request Test Coverage Report for Build 4133191606

  • 0 of 10 (0.0%) changed or added relevant lines in 7 files are covered.
  • 1270 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.1%) to 3.053%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/csp-measurement-tools/src/FlagTool.cpp 0 1 0.0%
plugins/csp-timings/src/Plugin.cpp 0 1 0.0%
src/cs-core/GuiManager.cpp 0 1 0.0%
src/cs-gui/GuiItem.cpp 0 1 0.0%
src/cs-gui/internal/RequestHandler.cpp 0 1 0.0%
src/cs-gui/internal/WebApp.cpp 0 1 0.0%
src/cs-gui/WebView.cpp 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
plugins/csp-measurement-tools/src/FlagTool.cpp 1 0%
plugins/csp-lod-bodies/src/LodBody.cpp 5 0%
plugins/csp-atmospheres/src/AtmosphereRenderer.cpp 12 67.32%
plugins/csp-stars/src/Plugin.cpp 13 0%
src/cs-core/Settings.hpp 19 0%
src/cs-core/Settings.cpp 35 0%
plugins/csp-anchor-labels/src/AnchorLabel.cpp 39 0%
plugins/csp-timings/src/Plugin.cpp 43 0%
src/cs-core/GraphicsEngine.cpp 75 0%
plugins/csp-wms-overlays/src/TextureOverlayRenderer.cpp 137 0%
Totals Coverage Status
Change from base Build 3854017668: 0.1%
Covered Lines: 515
Relevant Lines: 16868

💛 - Coveralls

Copy link
Member Author

@Schneegans Schneegans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I added two small comments 😉

make_externals.bat Outdated Show resolved Hide resolved
src/cs-gui/WebView.cpp Outdated Show resolved Hide resolved
@Schneegans
Copy link
Member Author

Thanks again! However, as this requires at least CMake 3.19 and as there are some compilation issues if Doxygen is installed, we will put this on hold for a couple of months.

@Schneegans Schneegans removed this from the Version 1.8.0 milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants