Rebuild comm package #60
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raynaudoe
approved these changes
Dec 20, 2023
common.go
Outdated
| // Validate HRP: Max length = 83 | ||
| // All characters must be in range [33, 126], displayable chars in Ledger devices | ||
| func serializeHRP(hrp string) (hrpBytes []byte, err error) { | ||
| if len(hrp) > 83 { |
There was a problem hiding this comment.
Avoid using magic numbers if possible, for example here you could create a constants.go file and add something like:
const (
HRP_MAX_LENGTH = 83
// all other constant values
)
common.go
Outdated
| return nil | ||
| hrpBytes = []byte(hrp) | ||
| for _, b := range hrpBytes { | ||
| if b < 33 || b > 126 { |
ftheirs
force-pushed
the
improvements
branch
from
5f873cd
to
282f630
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HDPath changed to string
The user can select which elements are hardened. The previous implementation used an array and the hardening was hidden from the user.
path := []uint32{44, 118, 0, 0, 21}path := "m/44'/118'/0'/0/21"Removed all legacy v1 and v2 functions
Sign function will require
Encapsulation from responses in structures
Fixed issues
#52
#53
#54