✨ Add insertParagraph buttons #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exemplary implementation of the insertParagraph buttons. The buttons need access to the current view to execute the command. Due to javascript scoping rules we have to provide a function to get the view when we need it instead of a reference to the view itself. Also, strange things are happening if we create the buttons right in the element where we need them. Thus creating them in a local variable and adding them when needed. ToDo: * decide where we actually want to use them * styling
micgro42
changed the title
Why didn't they show up during `yarn watch` ? o.O
The previous implementation was flawed beyond repair, because there was only ever a single instance of the buttons. They were in effect only attached to the very last element of those which were supposed to have them. This new implementation lets ProseMirror create the buttons and executes the event based on their class and get's the view from the global ProseMirror field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exemplary implementation of the insertParagraph buttons.
The buttons need access to the current view to execute the command. Due to javascript scoping rules we have to provide a function to get the view when we need it instead of a reference to the view itself.
Also, strange things are happening if we create the buttons right in the schema node where we need them. Thus creating them in a local variable and adding them when needed.
@annda, @JayDeeDee Please especially point out any places where you'd feel that more comments would be helpful in the future.
ToDo: