Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Download Datasets #431

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update Download Datasets #431

wants to merge 2 commits into from

Conversation

ljchang
Copy link
Member

@ljchang ljchang commented May 1, 2024

This PR updates nltools to accomodate the new functionality provided by nilearn version 0.10.4 to download and upload to neurovault.

Addresses Issues: #429 and #422

@ljchang
Copy link
Member Author

ljchang commented May 1, 2024

@ejolly I thought this was a WIP, but now I'm wondering if I've fixed the main issues. Basically, nilearn revamped how they were interfacing with nilearn. it actually looks like they did a nice job rethinking everything, but their new solution isn't really backwards compatible.

I just added a check to use either the new version or the old version for fetch_pain() and fetch_emotion_ratings() depending on the version of nilearn in the users environment. It's a little kludgy, but will ensure backwards compatibility.

I did not change any of the other helper functions as the download_nifti function doesn't use any nilearn code and the other two functions have now been replaced by nilearns new fetch_neurovault_ids function.

All of the tests are passing on my local version of python 3.11, if you want to review the code. It seems like we didn't have tests for the dataset module yet, which I guess we could add now.

@ljchang ljchang changed the title WIP: Update neurovault data i/o Update Download Datasets May 2, 2024
@ljchang ljchang requested a review from ejolly May 2, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant