Change modal cancel variant #1751
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
EmmyMay
force-pushed
the
2024.3.x-fix-modal-cancel
branch
from
f29e43c
to
b15360e
Compare
Fajfa
requested changes
Apr 15, 2024
There was a problem hiding this comment.
Three things:
- Search for
cancel-variant="link"and resolve those since we should be using that anymore. - Check all modals by searching for
<b-modalorcancel-titleor@cancel, and double check again please. There is a couple still that don't have the correct styles.
| rounded | ||
| class="text-primary" |
There was a problem hiding this comment.
Previously it wasn't obvious since it was a link, but this button doesn't have the correct margin. You can add gap to the footer
***Refactor field row view component in module*** ***Add small responsive design to unique values table*** ***Update system fields table in module edit view
EmmyMay
force-pushed
the
2024.3.x-fix-modal-cancel
branch
from
ecd40c8
to
62b524d
Compare
Fajfa
approved these changes
Apr 18, 2024
|
All looks good just this:
|
Fajfa
force-pushed
the
2024.3.x
branch
2 times, most recently
from
d2fcfdf
to
bf68606
Compare
Fajfa
approved these changes
Apr 30, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are implemented
TODO: Summary
Changes in the user interface:
TODO: Add screenshots, recordings or remove this section
Checklist when submitting a final (!draft) PR