Add decimal places to number columns in MSSQL #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temporary fix to store numbers with decimal places in MSSQL - use DECIMAL(18,6) instead of DECIMAL Signed-off-by: martkaczmarek <31852710+martkaczmarek@users.noreply.github.com>
|
Are you sure? Here it states that the default is 18 |
|
Ah... never mind; looked at the wrong thing.. my bad |
|
Yup, when defined as DECIMAL, the MSSQL engine assumes DECIMAL(18,0), meaning 18 digits but 0 to the right of the decimal point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temporary fix to store numbers with decimal places in MSSQL - use DECIMAL(18,6) instead of DECIMAL
The following changes are implemented
Use column type DECIMAL(18,6) instead of DECIMAL, which has no decimal places by default
Related to #1646