New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multivalue fields deduplication #1720
Open
KinyaElGrande
wants to merge
8
commits into
2024.3.x
Choose a base branch
from
2024.3.x-fix-module-fields-duplication
base: 2024.3.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested and pointed out a couple of issues in dms |
KinyaElGrande
force-pushed
the
2024.3.x-fix-module-fields-duplication
branch
from
March 22, 2024 10:25
662a862
to
eef8006
Compare
Fajfa
approved these changes
Mar 22, 2024
tjerman
reviewed
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider my two comments; else looks good 👍
tjerman
approved these changes
Mar 26, 2024
One more thing to be addressed and we should be good to go |
KinyaElGrande
force-pushed
the
2024.3.x-fix-module-fields-duplication
branch
from
April 24, 2024 15:17
6024876
to
a2926a7
Compare
Fajfa
force-pushed
the
2024.3.x
branch
2 times, most recently
from
April 29, 2024 13:33
d2fcfdf
to
bf68606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1434
The following PR introduces records multifield de-duplication check when multi-field values
equal
configuration is set.