Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multivalue fields deduplication #1720

Open
wants to merge 8 commits into
base: 2024.3.x
Choose a base branch
from

Conversation

KinyaElGrande
Copy link
Contributor

Ref: #1434

The following PR introduces records multifield de-duplication check when multi-field values equal configuration is set.

@katrinDY
Copy link
Contributor

Tested and pointed out a couple of issues in dms

@KinyaElGrande KinyaElGrande force-pushed the 2024.3.x-fix-module-fields-duplication branch from 662a862 to eef8006 Compare March 22, 2024 10:25
Copy link
Member

@tjerman tjerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider my two comments; else looks good 👍

server/compose/types/record_detect_duplicates.go Outdated Show resolved Hide resolved
server/compose/types/record_detect_duplicates.go Outdated Show resolved Hide resolved
@katrinDY
Copy link
Contributor

One more thing to be addressed and we should be good to go

@KinyaElGrande KinyaElGrande force-pushed the 2024.3.x-fix-module-fields-duplication branch from 6024876 to a2926a7 Compare April 24, 2024 15:17
@Fajfa Fajfa force-pushed the 2024.3.x branch 2 times, most recently from d2fcfdf to bf68606 Compare April 29, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test and ensure unique values work
5 participants