Suggestions #9
Merged
Suggestions #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
commented
Mar 1, 2024
Comment on lines
+9
to
+16
| RUN apk upgrade && \ | ||
| apk add \ | ||
| alpine-sdk \ | ||
| autoconf \ | ||
| automake \ | ||
| autoconf-archive \ | ||
| libtool \ | ||
| pkgconfig |
There was a problem hiding this comment.
See https://docs.docker.com/develop/develop-images/instructions/#apt-get
Why is pkgconfig and alpine-sdk required? Is it because we build GNU Autoconf from scratch later?
erlend-aasland
commented
Mar 1, 2024
|
|
||
| VOLUME /src | ||
| WORKDIR /src | ||
|
|
||
| ADD entry.sh / | ||
| CMD ["/entry.sh"] | ||
| CMD ["/entry.sh"] |
There was a problem hiding this comment.
Ooops, this was unintentional (I blame the GitHub UI editor)
erlend-aasland
commented
Mar 1, 2024
Comment on lines
+16
to
+21
| if [ "$#" = "0" ]; then | ||
| echo "Rebuilding configure script using $(autoconf --version | head -n 1)" | ||
| exec gosu autoreconf -ivf -Werror $@ | ||
| fi | ||
|
|
||
| exec "$@" |
There was a problem hiding this comment.
I think it can be nice to be able to run with arbitrary commands. For example:
$ docker run --rm -v$PWD:/src ghcr.io/corona10/cpython_autoconf:272-final autoconf --versionThere was a problem hiding this comment.
Also, gosu is perhaps overkill, but you never know. We may have to install it explicitly, though.
corona10
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.