fix(cornerstoneTools):Fetch the overlay if an async method is available #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayfarer3130
force-pushed
the
fix/overlay-asynchronous
branch
from
f269c29
to
80bc9e2
Compare
Codecov Report
@@ Coverage Diff @@
## master #1451 +/- ##
==========================================
- Coverage 20.16% 20.10% -0.06%
==========================================
Files 287 287
Lines 10102 10131 +29
Branches 2060 2069 +9
==========================================
Hits 2037 2037
- Misses 6852 6872 +20
- Partials 1213 1222 +9
Continue to review full report at Codecov.
|
wayfarer3130
commented
Nov 17, 2021
| * This method does depend on some of the JSON DICOM representations, but those don't have to come from | ||
| * JSON, it falls back to the original Uint8Array representation, which can come from anywhere. | ||
| */ | ||
| getOverlayData(pixelData, element) { |
There was a problem hiding this comment.
@chafey This is the asynchronous version of the retrieve code. It assumes 'dicom' format if the retrieveBulkData is present, which isn't unreasonable, and otherwise falls back to the existing behaviour. To do that, the retrieve call is made, but also the data is handled as InlineBinary and other various formats to support JSON based overlays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows the overlay tool to call an asynchronous retrieveBulkData method if the overlay pixeldata has a retrieveBulkData method, and then render the overlay correctly.