Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send emails and notifications for course requests #778

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Sydney-tran
Copy link
Contributor

@Sydney-tran Sydney-tran commented Nov 28, 2023

Summary

This PR adds code to send professors/tas both an email and a notification on QMI once their course request has been approved or rejected. Uses existing notification system to send notifications and uses EmailJS to send emails.

Screen Shot 2023-11-28 at 3 30 14 PM Screen Shot 2023-11-28 at 3 32 08 PM Screen Shot 2023-11-28 at 3 30 49 PM Screen Shot 2023-11-28 at 3 32 38 PM

Documentation:

Test Plan

  • Test prof/ta receives course request approved notification
  • Test prof/ta receives course request approved email
  • Test prof/ta receives course request rejected notification
  • Test prof/ta receives course request rejected email

Notes

In order to update email templates or review email history, sign into EmailJS with QMI email and password.

Breaking Changes

None

  • I have updated the documentation accordingly.
  • My PR adds a @ts-ignore

@Sydney-tran Sydney-tran requested a review from a team as a code owner November 28, 2023 21:39
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 904.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants