-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change edit courses frontend #777
base: master
Are you sure you want to change the base?
Conversation
[diff-counting] Significant lines: 285. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work with this so far Sophie, I like the documentation you included and how you maintained the styling in accordance with the rest of QMI. I think one thing that would be helpful, though, is if you included a couple screenshots of your changes so it's easier to see which frontend updates you made
moved selected classes to middle of screen, updated role position, moved heading and changed background need to do- fix courseText format to slightly lower, add search bar to top right of screen
Looks great so far! Just remember to check for lint errors. Your only error rn is an indentation one so should be a v small fix |
TODO: need to preserve currently enrolled courses (show as already selected)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working so hard on these changes! Looking at the edits you made, I think it's looking a lot better. Could you update the most recent dependencies/fix merge conflicts though? Having trouble running locally.
Summary
Changing the frontend of the edit classes page. Updating styling to be more aligned with the rest of the website.
previous design:
new design:
Test Plan
Breaking Changes
None