Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixing and Adding Tutorials to Pages #766

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

jewang25
Copy link
Contributor

@jewang25 jewang25 commented Oct 23, 2023

Summary

Continuing the tutorials feature from last semester by merging the alex/tutorial branch into this one. Working on styling and adding the workflow for student, ta, and professor tutorials.

TODO:

  • Create example OH, queue, and courses: for instances where new users don't have an active office hours to proceed on with in the tutorial, or for TA role a sample person in queue so they can see how to assign the question to themselves and such.
  • Test more thoroughly
  • Fix tutorial showing on admin dashboard

Test Plan

  • Run yarn start and walk through the tutorial to see each popover and each step. Compare with design to see if it matches and make sure there is no unexpected behavior
  • Test in all different roles (student, ta, and professor)

Notes

Need to make sure all code changes are necessary (still a work in progress) -> clean up code (condense into one tutorial file)

Breaking Changes

None

  • I have updated the documentation accordingly.
  • My PR adds a @ts-ignore

@jewang25 jewang25 requested a review from a team as a code owner October 23, 2023 00:38
@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 23, 2023

[diff-counting] Significant lines: 1096. This diff might be too big! Developer leads are invited to review the code.

@burninglilies
Copy link
Contributor

Great work so far :D

Copy link
Contributor

@erin-xu erin-xu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great so far! When I tested the student tutorial, the class I was on had no current office hour sessions, so the third and fourth pop ups appeared in the middle of the screen as shown in the image below. I'm not sure what the expected behavior is for this case.
Screenshot 2023-11-12 at 6 49 27 PM

Also, the last step highlighted the notification icon instead of the question mark.
Screenshot 2023-11-12 at 6 52 51 PM

@jewang25 jewang25 changed the title [WIP] Fixing and Adding Tutorials to Pages Fixing and Adding Tutorials to Pages Nov 13, 2023
@jewang25 jewang25 changed the title Fixing and Adding Tutorials to Pages [WIP] Fixing and Adding Tutorials to Pages Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants