Add team page alumni section #615
Conversation
|
[diff-counting] Significant lines: 107. |
|
Team picture is not showing up in the deploy preview |
| @@ -0,0 +1,24 @@ | |||
| { | |||
| "icons": [ | |||
| /> | ||
| <div className="flex flex-col gap-[20px] items-start"> | ||
| <h1 className="font-semibold lg:text-[32px] md:text-2xl">Want to join the family?</h1> | ||
| <p className="lg:text-[22px] md:text-lg">Applications for {semester} are open now!</p> |
There was a problem hiding this comment.
Food for thought - This is a section that can be changed a lot since it's related to recruitment.
At the very least, it seems like the semester needs to be changed every semester. But other than that, in general, the leads could ask to change the design of this entire section for a semester as they prepare for recruitment. Also, this historically is forgotten about, but while applications are open, it should say "Applications for Spring 2024 are open now!" but should probably be changed to "Applications for Spring 2024 are closed now :(" once it does close.
Basically in short, it might be nice to consider some ways to make this more modular for at the very least things like changing the semester and whether applications are open/closed. It might also be a good idea to pull this all out into its own component so it's more isolated logic and easier to completely swap out in the future.
As a general principle (this is my opinion), things that need to be frequently changed that don't change functionality are best pulled out of the direct code files with the logic into either configuration or constant value files (doesn't matter if it's .js/.ts or some data format file like .json or .yml)
There was a problem hiding this comment.
In no way is this saying this isn't ready to be merged btw!
I believe this is because the image path being used right now is the one consistent with #603 and not with main. Once that is merged in, the image should show up properly. |
Summary
This pull request is the third step towards implementing the team page. Included in this PR, is a template for the alumni and inactive members display section, beyond DTI section, and the bottom apply section.
Notion/Figma Link
https://www.figma.com/file/jKbvR1jVr1k80GGWnCpiRT/Website-Designs-SP23%2FFA23?type=design&node-id=5464-9095&mode=design&t=YKwLCHo5iC6MnFmk-0
Test Plan
Preview the website with the netlify deploy below or watch the video:
teamalumni.mp4
Notes