Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editing-shoutout - init_imp. #578

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

editing-shoutout - init_imp. #578

wants to merge 6 commits into from

Conversation

kevinmram
Copy link
Contributor

added a button and functions for editing shoutouts , allowing users to edit their shoutouts after submission.

  • implemented the (Edit) button.
  • implemented the (editShoutout, updateShoutout) functions.
  • display the updated shoutout- without reversion after a refresh...

@dti-github-bot
Copy link
Member

dti-github-bot commented Feb 12, 2024 •
edited

[diff-counting] Significant lines: 145.

patriciaahuang
patriciaahuang reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@patriciaahuang patriciaahuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I left a note about how to pass the last check. Also, it might be helpful to link the Notion ticket and an image for what you see on your end (edit button, success/error messages, etc), so reviewers can quickly check that we're see the same thing.

frontend/src/components/Forms/ShoutoutsPage/ShoutoutCard.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriciaahuang patriciaahuang patriciaahuang left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kevinmram @dti-github-bot @patriciaahuang @keverie