Attempt to upgrade to node 18 #445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 8. |
wizhaaa
changed the title
wizhaaa
changed the title
wizhaaa
added
dependencies
qiandrewj
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR works to upgrade to the next major node version - 18.
Node 18 introduces a lot of security improvements and many libraries we want to use requires node 18 (ie. OpenAI)...
Also does not run the test script - replaced with a no-op command
:as I think Jest will break too much and isn't worth it right now.Be sure to update your global default node if you don't want to manually type out
nvm use 18every time!->
PR Type
Mobile + Desktop Screenshots & Recordings
QA - Test Plan
Breaking Changes & Notes
Using the SSL flag for our react-script functions is not actually ideal - as it definitely introduces some security concerns - but I think that this is for the best.
IE. react scripts only really supports node 16. This is the main workaround I could find for react-scripts. The long term solution would be to change from react-scripts to vite (which I attempted earlier but required node 18 - but may attempt once again.)
Added to documentation?
What GIF represents this PR?
gif