Added filter for disability in Student page #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 34. |
Atikpui007
requested changes
Apr 14, 2024
There was a problem hiding this comment.
Looks pretty good and I like that you are picking up Typescript and learning the industry conventions with typing. I however would like us to use the react-select library for all dropdowns to maintain consistency.
So for now your PR will be blocked until the React-select library is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added filter for disability in Student page. Works with search bar and the show active/inactivate student option. As there are currently no designs for this filter box or any requirements on what to filter, I chose to filter by disability.
Students.-.Carriage.-.Google.Chrome.2024-04-04.20-08-15.mp4
Test Plan
I tested it manually on different inputs and it seems to work correctly. I don't know much about the correct (or any) approach to testing in this case so any input on this area would be greatly appreciated.
Notes
Everything seems to work fine.