Student address requirements #501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 23. |
raissaji
changed the title
namanhboi
reviewed
May 5, 2024
| @@ -165,7 +165,7 @@ const RiderModalInfo = ({ | |||
| aria-required="true" | |||
| ref={register({ | |||
| required: true, | |||
| pattern: /^[a-zA-Z0-9\s,.'-]{3,}$/, | |||
| validate: (value) => value.trim() !== '', | |||
There was a problem hiding this comment.
Hi Raissa, you did a great job on this PR as your code was both simple and correct. Just a sidenote, but if you wanted to do this with regex, you could use: pattern : /^(?!\s*$).+/, which represents strings with at least one non empty character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request removes the address parsing condition within isAddress. It also removes the requirement that the input be at least 3 characters long in RiderModalInfo.tsx. Now, any address input that is not empty or spaces will be valid. This is to resolve the inconsistent add/edit behavior noted in PR #425 regarding the address field.
Test Plan
Attempting to submit an address input of just spaces will alert the error message.
Attempting to submit an empty address input will also alert the error message.
Previously, the input "300 Day Hall" wouldn't have worked. Now, 300 Day Hall is parsed and appended with ", Ithaca, NY 14850" to be a valid address.
Notes
Breaking Changes
None