Made changes to enable compilation. #716
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since clones from the source repo running build.bat would fail to compile and/or generate a setup file. These changes enable it to compile and to reduce the number of error messages generated during build. 1. Added a check in build.bar to look for file named GOTIDY and if found it will run `go mod tidy` before each `go build` 2. Added a check for buildtools\signtool.exe and if not found displays a message with a URL where it can be downloaded. 3. `VersionInfoTextVersion` and `VersionInfoProductTextVersion` to nvm.iss to stop InnoSetup from generating a warning message about them 4. Added TODO about fixing InnoSetup message related to `PrivilegesRequired` See: https://stackoverflow.com/a/44575671/102699 5. Added golang.org/x/sys in go.mod for updater to get it to compile. 6. Removed the replace in go.mod for nvm that referred to author's local machine and updated go-fsutil require from v1.1.1 to v1.2.0 7. DID NOT FIX SignTool Error: "No certificates were found that met all the given criteria."
|
This PR is stale because it has been open 45 days with no activity. |
|
l |
guilhermodev
approved these changes
Apr 1, 2022
|
This PR is stale because it has been open 45 days with no activity. |
|
@guilhermodev Updated to resolve the merge conflict. |
|
This PR is stale because it has been open 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to get this to compile. These are my fixes if you want them.
I cloned this project to check it out and see if I could learn from it, but quickly found out that it wouldn't compile. So after spending several hours fixing it to compile, I figured I should at least share my effort with you the owner of the repo in case you do want to accept the fixes. Below is the commit message:
==================================
Since clones from the source repo running build.bat would fail to compile
and/or generate a setup file. These changes enable it to compile and to
reduce the number of error messages generated during build.
it will run
go mod tidybefore eachgo buildmessage with a URL where it can be downloaded.
VersionInfoTextVersionandVersionInfoProductTextVersionto nvm.issto stop InnoSetup from generating a warning message about them
PrivilegesRequiredSee: https://stackoverflow.com/a/44575671/102699
machine and updated go-fsutil require from v1.1.1 to v1.2.0
the given criteria."