Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade WinSW to 2.0.1 #268

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade WinSW to 2.0.1 #268

wants to merge 1 commit into from

Conversation

nxtn
Copy link

@nxtn nxtn commented Aug 6, 2020

WinSW 2 carries a logging framework so the binary is a bit larger.

Also removes .NET 2 support. Who is using .NET 2 these days?

Fixes #47


Bug fixes

  • Prevent CPU overutilization when waiting for the process to exit.
  • Properly retrieve waithint, sleeptime, resetfailure, and stoptimeout options from XML configs with metadata before settings.
  • Print warnings in the uninstall command when the service cannot be uninstalled immediately.
  • Prevent failure when stoparguments are defined without stopexecutable in the XML file.
  • Prevent failure during process termination if child processes cannot be retrieved due to the pending system shutdown.
  • Security: Do not dump WinSW environment variables to the Event log.
  • Do not propagate exceptions from Process.Kill() if the process actually exits.

Compatibility notes

  • WinSW v2 is fully compatible with WinSW v1 in terms of the command-line interface and configuration files.

@coreybutler
Copy link
Owner

I'll consider this, depending on how much time I get. I've been working on an alternative to winsw, so this may not be necessary.

@nxtn
Copy link
Author

nxtn commented Aug 6, 2020

We're now building WinSW 3, and it's surprising to see this project is still using WinSW 1. A large number of issues in this repo have been resolved in the upstream.

I've been working on an alternative to winsw

Why reinvent the wheel? Is it written in Golang?

@coreybutler
Copy link
Owner

Yes, alternative is in Go. It's not recreating the wheel for me, because I'm building it for another effort.

Again, not opposed to merging this, I just need to test it/confirm and make sure I can continue to support it.

@nxtn
Copy link
Author

nxtn commented Aug 11, 2020

Sounds good. I'm also considering rewriting WinSW in a different language, but I don't regard Go as a competitive choice. I would prefer a native language like Rust this time.

@udany
Copy link

udany commented Dec 7, 2020

Would this also address issue #53 and allow node-windows to set a StartupType?

@nxtn
Copy link
Author

nxtn commented Dec 8, 2020

Would this also address issue #53 and allow node-windows to set a StartupType?

Yeah. There may be more ancient issues fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install Service not working on Windows 8.1 and .NET 4.5
3 participants