Implement command line args for script/program. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll get a README update commit later today to show how to use new config option. Just wanted to get this in in case someone see's something wrong with my approach. |
|
Let me know if you like the api/approach. |
|
At first glance, this looks good. I'll test it out this weekend. Thanks! |
| @@ -135,8 +137,13 @@ var launch = function(){ | |||
|
|
|||
| // Fork the child process | |||
| var opts = {env:process.env}; | |||
| var args; | |||
| if (argv.args) { | |||
| args = argv.args.split(' '); | |||
There was a problem hiding this comment.
This call to split seems a bit dangerous. Should quoted arguments with space characters (such as '1 2 "3 4"') be handled differently?
|
Hello: I am curious to know the status of this task. We would like to run a Node file as service but the js file takes arguments. |
|
I would say to create a wrapper with the specific arguments in it to avoid having any sort of xml encoding hiccups. Or possibly by using environment variables instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #100