Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time constrained order tokens #2574

Draft
wants to merge 16 commits into
base: 3.2
Choose a base branch
from

Conversation

TanaseTeofil
Copy link
Contributor

Closes #2568

@CLAassistant
Copy link

CLAassistant commented Mar 5, 2024

CLA assistant check
All committers have signed the CLA.

@dpfaffenbauer
Copy link
Member

@TanaseTeofil can you also please implement how you validate the token. I also think that JWT is a bit overkill. What if we use our Token Generator and just increase the length to 64 chars or so? this is for example how payum generates the tokens: https://github.com/Payum/Payum/blob/master/src/Payum/Core/Security/Util/Random.php#L21

@TanaseTeofil
Copy link
Contributor Author

TanaseTeofil commented Mar 13, 2024

@TanaseTeofil can you also please implement how you validate the token. I also think that JWT is a bit overkill. What if we use our Token Generator and just increase the length to 64 chars or so? this is for example how payum generates the tokens: https://github.com/Payum/Payum/blob/master/src/Payum/Core/Security/Util/Random.php#L21

@dpfaffenbauer That might be enough. I will discuss this with @yariksheptykin next week. Currently I am not available to work on this.

@TanaseTeofil
Copy link
Contributor Author

Hello @solverat !

We've decided to move forward with your suggestion on the issue #2568
Can you provide a bit more details on how this configurable_ttl is configured and also how the tokenLength is decided?
Is token length something we give on generation as a parameter to the UniqueTokenGenerator only or is it configured somewhere else?
Any additional details you can provide on how you would implement this would be greatly appreciated.

@TanaseTeofil
Copy link
Contributor Author

Hello @solverat !

We've decided to move forward with your suggestion on the issue #2568 Can you provide a bit more details on how this configurable_ttl is configured and also how the tokenLength is decided? Is token length something we give on generation as a parameter to the UniqueTokenGenerator only or is it configured somewhere else? Any additional details you can provide on how you would implement this would be greatly appreciated.

@dpfaffenbauer Can you help with this?

@dpfaffenbauer
Copy link
Member

@TanaseTeofil I would make it configurable with a symfony config and inject it with DI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants