[Order] allow passing custom-attributes from price rules to order-item #2555
Conversation
|
@EinShoppo rest is now implemented as well |
# Conflicts: # .github/workflows/behat.yml # .github/workflows/behat_ui.yml # .github/workflows/packages_bundles.yml # .github/workflows/packages_components.yml # .github/workflows/static.yml # docs/03_Bundles/Resource_Bundle/02_Pimcore_Entities.md
|
@EinShoppo do you wanna give this a test? |
|
@dpfaffenbauer: Sounds great! One of my colleagues and I are looking at this today. I think you'll get feedback from us tomorrow at the latest. |
|
@dpfaffenbauer We finished our tests and it works like a charm! Big cheers and many thanks 👍 A possible improvement would be to also check for the presence of the not-discountable attribute in the product price rules, but this is probably technically more difficult to implement. So you can see it more as an idea for the future. |
|
@EinShoppo nice :). Ok, then we can merge this into the 4.1 branch. you then have to update your project to 4.1 to use that ok? |
|
@dpfaffenbauer We planed to update to 4.0 before, so this shouldn't be a big problem for us. Do you already know when it will be released? |
|
@EinShoppo probably after Pimcore Inspire. Are you faster than that? |
|
@dpfaffenbauer: I'm not sure, but if necessary we'll have to temporarily fork or patch the 4.0 version. |
|
@EinShoppo let's have a chat next week and discuss that, can you contact me directly? |
|
|
@EinShoppo this is not ready yet, but the basic idea behind what we discussed. The idea is to allow passing custom attributes from pricing calculation to be stored in the order, thus using them to affect price calculation from cart-price-rules. (or basically anything cart-item-related). WDYT?
It is still missing parts like persistence of attributes or the cart-price-rule-condition to not allow non-discountable.