[JMS] allow v5

.github/workflows/behat.yml

@@ -42,10 +42,8 @@ jobs:
       matrix:
         php: [ 8.1, 8.2 ]
         pimcore: [ ~11.1.0, ~11.2.0 ]
+        jms: [ ^4.0, ^5.0 ]
         dependencies: [ highest ]
-        exclude:
-          - php: 8.1
-            dependencies: lowest
 
     services:
       database:
@@ -55,7 +53,7 @@ jobs:
         ports:
           - 3306:3306
         options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
-    name: "${{ matrix.pimcore }}, PHP ${{ matrix.php }}, Deps ${{ matrix.dependencies }}"
+    name: "${{ matrix.pimcore }}, PHP ${{ matrix.php }}, Deps ${{ matrix.dependencies }}, JMS ${{ matrix.jms }}"
 
     steps:
     - uses: actions/checkout@v4
@@ -85,17 +83,19 @@ jobs:
         key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}
         restore-keys: ${{ runner.os }}-composer-
 
+    - name: jms/serializer-bundle
+      run: composer require "jms/serializer-bundle:${{ matrix.jms }}" --no-update --no-scripts
+
+    - name: pimcore/pimcore
+      run: composer req pimcore/pimcore:${{ matrix.pimcore }} --no-interaction --no-scripts --no-update
+
     - if: matrix.dependencies == 'highest'
       name: Install dependencies highest
-      run: |
-        composer req pimcore/pimcore:${{ matrix.pimcore }} --no-interaction --no-scripts --no-update
-        composer update --no-progress --prefer-dist --optimize-autoloader
+      run: composer update --no-progress --prefer-dist --optimize-autoloader
 
     - if: matrix.dependencies == 'lowest'
       name: Install dependencies lowest
-      run: |
-        composer req pimcore/pimcore:${{ matrix.pimcore }} --no-interaction --no-scripts --no-update
-        composer update --no-progress --prefer-dist --optimize-autoloader --prefer-lowest
+      run: composer update --no-progress --prefer-dist --optimize-autoloader --prefer-lowest
 
     - name: Cache clear
       run: bin/console cache:clear

.github/workflows/behat_ui.yml

@@ -39,6 +39,7 @@ jobs:
       matrix:
         php: [ 8.1, 8.2 ]
         pimcore: [ ~11.1.0, ~11.2.0 ]
+        jms: [ ^4.0, ^5.0 ]
         dependencies: [ highest ]
         exclude:
           - php: 8.1
@@ -52,8 +53,7 @@ jobs:
         ports:
           - 3306:3306
         options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
-
-    name: "${{ matrix.pimcore }}, PHP ${{ matrix.php }}, Deps ${{ matrix.dependencies }}"
+    name: "${{ matrix.pimcore }}, PHP ${{ matrix.php }}, Deps ${{ matrix.dependencies }}, JMS ${{ matrix.jms }}"
 
     steps:
     - uses: actions/checkout@v4
@@ -84,17 +84,19 @@ jobs:
         key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}
         restore-keys: ${{ runner.os }}-composer-
 
+    - name: jms/serializer-bundle
+      run: composer require "jms/serializer-bundle:${{ matrix.jms }}" --no-update --no-scripts
+
+    - name: pimcore/pimcore
+      run: composer req pimcore/pimcore:${{ matrix.pimcore }} --no-interaction --no-scripts --no-update
+
     - if: matrix.dependencies == 'highest'
       name: Install dependencies highest
-      run: |
-        composer req pimcore/pimcore:${{ matrix.pimcore }} --no-interaction --no-scripts --no-update
-        composer update --no-progress --prefer-dist --optimize-autoloader
+      run: composer update --no-progress --prefer-dist --optimize-autoloader
 
     - if: matrix.dependencies == 'lowest'
       name: Install dependencies lowest
-      run: |
-        composer req pimcore/pimcore:${{ matrix.pimcore }} --no-interaction --no-scripts --no-update
-        composer update --no-progress --prefer-dist --optimize-autoloader --prefer-lowest
+      run: composer update --no-progress --prefer-dist --optimize-autoloader --prefer-lowest
 
     - name: Cache clear
       run: bin/console cache:clear

.github/workflows/packages_bundles.yml

@@ -43,9 +43,6 @@ jobs:
         pimcore: [ ~11.1.0, ~11.2.0 ]
         dependencies: [ highest ]
         package: "${{ fromJson(needs.list.outputs.packages) }}"
-        exclude:
-          - php: 8.1
-            dependencies: lowest
 
     steps:
     - uses: actions/checkout@v4
@@ -73,20 +70,22 @@ jobs:
       run: composer validate --ansi --strict
       working-directory: "src/CoreShop/${{ matrix.package }}"
 
+    - name: pimcore/pimcore
+      run: composer req pimcore/pimcore:${{ matrix.pimcore }} --no-interaction --no-scripts --no-update
+      env:
+        COMPOSER_ROOT_VERSION: dev-master
+      working-directory: "src/CoreShop/${{ matrix.package }}"
+
     - if: matrix.dependencies == 'highest'
       name: Install dependencies highest
-      run: |
-        composer req pimcore/pimcore:${{ matrix.pimcore }} --no-interaction --no-scripts --no-update
-        composer update --no-progress --prefer-dist --optimize-autoloader
+      run: composer update --no-progress --prefer-dist --optimize-autoloader
       env:
         COMPOSER_ROOT_VERSION: dev-master
       working-directory: "src/CoreShop/${{ matrix.package }}"
 
     - if: matrix.dependencies == 'lowest'
       name: Install dependencies lowest
-      run: |
-        composer req pimcore/pimcore:${{ matrix.pimcore }} --no-interaction --no-scripts --no-update
-        composer update --no-progress --prefer-dist --optimize-autoloader --prefer-lowest
+      run: composer update --no-progress --prefer-dist --optimize-autoloader --prefer-lowest
       env:
         COMPOSER_ROOT_VERSION: dev-master
       working-directory: "src/CoreShop/${{ matrix.package }}"

.github/workflows/packages_components.yml

@@ -43,9 +43,6 @@ jobs:
         pimcore: [ ~11.1.0, ~11.2.0 ]
         dependencies: [ highest ]
         package: "${{ fromJson(needs.list.outputs.packages) }}"
-        exclude:
-          - php: 8.1
-            dependencies: lowest
 
     steps:
     - uses: actions/checkout@v4
@@ -73,20 +70,22 @@ jobs:
       run: composer validate --ansi --strict
       working-directory: "src/CoreShop/${{ matrix.package }}"
 
+    - name: pimcore/pimcore
+      run: composer req pimcore/pimcore:${{ matrix.pimcore }} --no-interaction --no-scripts --no-update
+      env:
+        COMPOSER_ROOT_VERSION: dev-master
+      working-directory: "src/CoreShop/${{ matrix.package }}"
+
     - if: matrix.dependencies == 'highest'
       name: Install dependencies highest
-      run: |
-        composer req pimcore/pimcore:${{ matrix.pimcore }} --no-interaction --no-scripts --no-update
-        composer update --no-progress --prefer-dist --optimize-autoloader
+      run: composer update --no-progress --prefer-dist --optimize-autoloader
       env:
         COMPOSER_ROOT_VERSION: dev-master
       working-directory: "src/CoreShop/${{ matrix.package }}"
 
     - if: matrix.dependencies == 'lowest'
       name: Install dependencies lowest
-      run: |
-        composer req pimcore/pimcore:${{ matrix.pimcore }} --no-interaction --no-scripts --no-update
-        composer update --no-progress --prefer-dist --optimize-autoloader --prefer-lowest
+      run: composer update --no-progress --prefer-dist --optimize-autoloader --prefer-lowest
       env:
         COMPOSER_ROOT_VERSION: dev-master
       working-directory: "src/CoreShop/${{ matrix.package }}"

.github/workflows/static.yml

@@ -28,11 +28,8 @@ jobs:
       matrix:
         php: [ 8.1, 8.2 ]
         pimcore: [ ~11.1.0, ~11.2.0 ]
+        jms: [ ^4.0, ^5.0 ]
         dependencies: [ highest ]
-        exclude:
-          - php: 8.1
-            dependencies: lowest
-
     services:
       database:
         image: "mysql:8"
@@ -42,8 +39,7 @@ jobs:
         ports:
           - 3306:3306
         options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
-
-    name: "${{ matrix.pimcore }}, PHP ${{ matrix.php }}, Deps ${{ matrix.dependencies }}"
+    name: "${{ matrix.pimcore }}, PHP ${{ matrix.php }}, Deps ${{ matrix.dependencies }}, JMS ${{ matrix.jms }}"
 
     steps:
     - uses: actions/checkout@v4
@@ -69,17 +65,19 @@ jobs:
         key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}
         restore-keys: ${{ runner.os }}-composer-
 
+    - name: jms/serializer-bundle
+      run: composer require "jms/serializer-bundle:${{ matrix.jms }}" --no-update --no-scripts
+
+    - name: pimcore/pimcore
+      run: composer req pimcore/pimcore:${{ matrix.pimcore }} --no-interaction --no-scripts --no-update
+
     - if: matrix.dependencies == 'highest'
       name: Install dependencies highest
-      run: |
-        composer req pimcore/pimcore:${{ matrix.pimcore }} --no-interaction --no-scripts --no-update
-        composer update --no-progress --prefer-dist --optimize-autoloader
+      run: composer update --no-progress --prefer-dist --optimize-autoloader
 
     - if: matrix.dependencies == 'lowest'
       name: Install dependencies lowest
-      run: |
-        composer req pimcore/pimcore:${{ matrix.pimcore }} --no-interaction --no-scripts --no-update
-        composer update --no-progress --prefer-dist --optimize-autoloader --prefer-lowest
+      run: composer update --no-progress --prefer-dist --optimize-autoloader --prefer-lowest
 
     - name: Validate YAML
       run: bin/console lint:yaml src

.gitignore

@@ -61,4 +61,5 @@ docs/build
 docs/node_modules
 docs/.docusaurus
 node_modules
-docker-compose.override.yaml
+cache/
+docker-compose.override.yaml

composer.json

@@ -94,7 +94,7 @@
     "doctrine/orm": "^2.9",
     "fakerphp/faker": "^1.16",
     "gedmo/doctrine-extensions": "^3.11",
-    "jms/serializer-bundle": "^4.0",
+    "jms/serializer-bundle": "^4.0 | ^5.0",
     "knplabs/knp-menu-bundle": "^3.1",
     "laminas/laminas-stdlib": "^3.6",
     "laminas/laminas-zendframework-bridge": "^1.5",

src/CoreShop/Bundle/CustomerBundle/Resources/config/serializer/Model.Customer.yml

@@ -2,6 +2,11 @@ CoreShop\Component\Customer\Model\Customer:
     exclusion_policy: ALL
     xml_root_name: customer
     virtual_properties:
+        id:
+            serialized_name: id
+            exp: object.getId()
+            type: string
+            groups: [Detailed]
         salutation:
             serialized_name: salutation
             exp: object.getSalutation()
@@ -37,4 +42,9 @@ CoreShop\Component\Customer\Model\Customer:
             exp: object.getCustomerGroups()
             type: array
             groups: [Detailed]
+        creationDate:
+            serialized_name: creationDate
+            exp: object.getCreationDate()
+            type: int
+            groups: [Detailed]
 

src/CoreShop/Bundle/ResourceBundle/Resources/config/services.yml

@@ -77,19 +77,22 @@ services:
             - '@translator'
 
     CoreShop\Bundle\ResourceBundle\Serialization\Driver\PimcoreDataObjectDriver:
-        decorates: 'jms_serializer.metadata.annotation_driver'
+        decorates: 'jms_serializer.metadata_driver'
         arguments:
             - '@CoreShop\Bundle\ResourceBundle\Serialization\Driver\PimcoreDataObjectDriver.inner'
 
     CoreShop\Bundle\ResourceBundle\EventListener\DeepCopySubscriber:
         tags:
             - { name: kernel.event_subscriber }
 
+    coreshop.jms_serializer.object_constructor:
+        class: JMS\Serializer\Construction\UnserializeObjectConstructor
+
     CoreShop\Bundle\ResourceBundle\Serialization\VersionObjectConstructor:
         decorates: 'jms_serializer.object_constructor'
         arguments:
             - '@CoreShop\Bundle\ResourceBundle\Serialization\VersionObjectConstructor.inner'
-            - '@jms_serializer.unserialize_object_constructor'
+            - '@coreshop.jms_serializer.object_constructor'
 
     CoreShop\Component\Resource\Service\FolderCreationServiceInterface: '@CoreShop\Component\Resource\Service\FolderCreationService'
     CoreShop\Component\Resource\Service\FolderCreationService:

src/CoreShop/Bundle/ResourceBundle/composer.json

@@ -26,7 +26,7 @@
   "require": {
     "doctrine/orm": "^2.9",
     "doctrine/doctrine-bundle": "^2.4",
-    "jms/serializer-bundle": "^4.0",
+    "jms/serializer-bundle": "^4.0 | ^5.0",
     "stof/doctrine-extensions-bundle": "^1.6",
     "coreshop/pimcore-bundle": "^4.0",
     "coreshop/locale-bundle": "^4.0",