id token: allow to set claims #329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicola Murino <nicola.murino@gmail.com>
|
I am also looking for a way to set claims on a IDToken for my test cases and this method would be super helpful! @ericchiang Could you provide your inputs on this PR? |
|
This is a nice change and I too would find it useful in setting claims during unit tests. I noticed the PR is getting quite old; Is there anything the maintainers need to push this forward? Thank you! |
|
working link to the reflect hack: https://github.com/drakkan/sftpgo/blob/1fccd05e9e6d2e33b74939f9ee493111548256f7/httpd/oidc_test.go#L72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is similar to this one.
I need a way, in my test cases, to return an ID Token from my mock verifier, I currently use this reflect hack.