Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stub to fix build on macOS #131

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add stub to fix build on macOS #131

wants to merge 2 commits into from

Conversation

elad
Copy link

@elad elad commented May 12, 2021

No description provided.

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #131 (7e6b8d4) into master (eface94) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   33.60%   33.60%           
=======================================
  Files          12       12           
  Lines         622      622           
=======================================
  Hits          209      209           
  Misses        371      371           
  Partials       42       42           
Flag Coverage Δ
unittests 33.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eface94...7e6b8d4. Read the comment docs.

@Natolumin
Copy link
Member

Afaict (although I can't test) #129 should also fix the build, without causing a runtime error; can you test that branch ?

@elad
Copy link
Author

elad commented Jun 9, 2021

It doesn’t seem like it:

$ git show --summary
commit 755c9769cbd1291574f8397f7ef1a2ac5ee9134c (HEAD -> raw_socket, origin/raw_socket)
Author: Anatole Denis <anatole@unverle.fr>
Date:   Sat Apr 24 15:57:16 2021 +0200

    server: Select an appropriate IP address for L2 unicast
    
    When deferring to the system routing, the ip address is automatically
    selected by the kernel.
    We were previously using the message's ServerIPAddr, but that is
    incorrect as a source address since that is the address of the next
    server, and not necessarily the address of the current server or an
    address that is routable by the client
    
    Signed-off-by: Anatole Denis <anatole@unverle.fr>

$ go build ./...
# github.com/coredhcp/coredhcp/server
server/handle.go:182:11: l.sendEthernet undefined (type *listener4 has no field or method sendEthernet)
server/serve.go:152:12: l4.tryOpenRawSock undefined (type *listener4 has no field or method tryOpenRawSock)
$ 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants