Merge pull request #4608 from coralproject/develop

v9.0.4
coralproject · May 1, 2024 · af8ea5b · af8ea5b
2 parents 04434c3 + f19f05b
commit af8ea5b
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 7 deletions.
diff --git a/client/package.json b/client/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@coralproject/talk",
-  "version": "9.0.3",
+  "version": "9.0.4",
   "author": "The Coral Project",
   "homepage": "https://coralproject.net/",
   "sideEffects": [

diff --git a/client/src/core/client/stream/events.ts b/client/src/core/client/stream/events.ts
@@ -463,7 +463,7 @@ export const ViewConversationEvent = createViewerEvent<{
  */
 export const ViewNotificationsFeedEvent = createViewerEvent<{
   userID?: string;
-}>("viewNotificationsFeedEvent");
+}>("viewNotificationsFeed");
 
 /**
  * This event is emitted when the viewer clicks

diff --git a/common/package.json b/common/package.json
@@ -1,6 +1,6 @@
 {
   "name": "common",
-  "version": "9.0.3",
+  "version": "9.0.4",
   "description": "",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/config/package.json b/config/package.json
@@ -1,6 +1,6 @@
 {
   "name": "common",
-  "version": "9.0.3",
+  "version": "9.0.4",
   "description": "",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/server/package.json b/server/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@coralproject/talk",
-  "version": "9.0.3",
+  "version": "9.0.4",
   "author": "The Coral Project",
   "homepage": "https://coralproject.net/",
   "sideEffects": [

diff --git a/server/src/core/server/stacks/approveComment.ts b/server/src/core/server/stacks/approveComment.ts
@@ -7,7 +7,10 @@ import { retrieveNotificationByCommentReply } from "coral-server/models/notifica
 import { Tenant } from "coral-server/models/tenant";
 import { retrieveUser } from "coral-server/models/user";
 import { retrieveComment } from "coral-server/services/comments";
-import { moderate } from "coral-server/services/comments/moderation";
+import {
+  moderate,
+  PENDING_STATUS,
+} from "coral-server/services/comments/moderation";
 import { I18n } from "coral-server/services/i18n";
 import { InternalNotificationContext } from "coral-server/services/notifications/internal/context";
 import { AugmentedRedis } from "coral-server/services/redis";
@@ -93,7 +96,8 @@ const approveComment = async (
     }
   }
 
-  if (createNotification) {
+  // only create notification upon approval of comments with previous pending status
+  if (createNotification && PENDING_STATUS.includes(result.before.status)) {
     await notifications.create(tenant.id, tenant.locale, {
       targetUserID: result.after.authorID!,
       comment: result.after,