Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Tests #91

Open
wants to merge 18 commits into
base: gallego-posada/1.0.0-alpha
Choose a base branch
from
Open

Refactor Tests #91

wants to merge 18 commits into from

Conversation

merajhashemi
Copy link
Collaborator

No description provided.

@merajhashemi merajhashemi changed the base branch from master to merajhashemi/refactor-cmp May 1, 2024 20:07
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (gallego-posada/1.0.0-alpha@9f94213). Learn more about missing BASE report.

❗ Current head dbf6fa3 differs from pull request most recent head d0fa38d

Please upload reports for the commit d0fa38d to get more accurate results.

Additional details and impacted files 
@@                      Coverage Diff                      @@
##             gallego-posada/1.0.0-alpha      #91   +/-   ##
=============================================================
  Coverage                              ?   80.17%           
=============================================================
  Files                                 ?       28           
  Lines                                 ?      938           
  Branches                              ?        0           
=============================================================
  Hits                                  ?      752           
  Misses                                ?      186           
  Partials                              ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from merajhashemi/refactor-cmp to gallego-posada/1.0.0-alpha May 14, 2024 14:56
merajhashemi
merajhashemi commented May 14, 2024
View reviewed changes
tests/test_pipeline.py Outdated Show resolved Hide resolved
merajhashemi
merajhashemi commented May 14, 2024
View reviewed changes
tests/helpers/cooper_test_utils.py
def compute_violations(self, x: torch.Tensor) -> cooper.CMPState:
"""
Computes the constraint violations for the given parameters.
"""
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment that sampling for strict violation and violation is different

merajhashemi
merajhashemi commented May 14, 2024
View reviewed changes
tests/test_pipeline.py Outdated
self.device = device

def test_convergence(self, extrapolation, alternation_type):
x = torch.nn.Parameter(torch.ones(5, device=self.device))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start from random init

merajhashemi
merajhashemi commented May 14, 2024
View reviewed changes
tests/test_pipeline.py Outdated Show resolved Hide resolved
merajhashemi
merajhashemi commented May 14, 2024
View reviewed changes
tests/test_pipeline.py Outdated Show resolved Hide resolved
merajhashemi
merajhashemi commented May 14, 2024
View reviewed changes
tests/test_pipeline.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@merajhashemi @codecov-commenter