New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CMP and CMPState #86
Merged
merajhashemi
merged 149 commits into
gallego-posada/1.0.0-alpha
from
merajhashemi/refactor-cmp
May 14, 2024
Merged
Refactor CMP and CMPState #86
merajhashemi
merged 149 commits into
gallego-posada/1.0.0-alpha
from
merajhashemi/refactor-cmp
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename ConstraintStore to ConstraintMeasurement Remove lagrangian contribution from ConstraintMeasurement
…' into merajhashemi/refactor-optimizers # Conflicts: # cooper/formulations/utils.py
juan43ramirez
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMP and CMPState
LagrangianStore
.backward
method from CMPState toLagrangianStore
.CMPState
replacing direct attributes such asself.lagrangian
andself.dual_lagrangian
.dual_parameters()
method for fetching multiplier parameters for instantiating the dual optimizerPenaltyCoefficients
nn.module
.__call__
inno_grad
mode for efficiency.def __call__(self, *args, **kwargs):
in the base class for consistency.__call__
to return cloned values.PenaltyCoefficientUpdater
to handle update schemes for penalty coefficients.Updates from #88
Constraint
ConstraintType
enum to separate module to resolve circular dependency issues betweenConstraint
,Formulation
andMultiplier
.Formulations
PenaltyFormulation
andQuadraticPenaltyFormulation
PenaltyFormulation
is deprecated in favor of asking users to formulate penalized tasks directly through their objective functionQuadraticPenaltyFormulation
. We will add a tutorial to illustrate the use of a Quadratic Penalty formulation in Cooper.LagrangianFormulation
andAugmentedLagrangianFormulation
remain. Now it is mandatory to provide aMultiplier
when building a formulation.FormulationType
.penalty_growth_factor
andviolation_tolerance
.Multipliers
init
tensor (if provided) to have shape(num_constraints,)
. Else,num_constraints:int
is expected and we initialize the multipliers with zeros of shape(num_constraints,)
.dual_restarts
.enforce_positive
attribute tois_inequality
property.ExplicitMultipliers
Updates from #89
Updates from #90
CooperOptimizer
abstract base classConstrainedOptimizer
andUnconstrainedOptimizer
inherit fromCooperOptimizer
RollOut
for organizing returns ofroll
methodConstraintMeasurement
ContributionStore