Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voting status for participants #176

Merged
merged 37 commits into from Apr 29, 2024

Conversation

ElviaBth
Copy link
Collaborator

@ElviaBth ElviaBth commented Mar 26, 2024

🎩 What? Why?
Add voting status for participants for each question.

📌 Related Issues
#175
#174 Enlarge delegation button

📷 Screenshots

  • If the user has not answered all the questions, should look "pending":
    image

  • If the user has answered all questions, should look "success":
    image

  • When clicking on the message, a modal window should appear with a summary of all the questions and it's current status:
    image
    This modal is have a link to any non-answered question

  • Create a simple system test to check the modal is opened

  • Delegation button current status before vote:
    image

  • Delegation button current status after vote:
    image

♥️ Thank you!

@ElviaBth ElviaBth changed the title Add voting status for participants" Add voting status for participants Mar 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (b481bde) to head (b015062).

❗ Current head b015062 differs from pull request most recent head 870d181. Consider uploading reports for the commit 870d181 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files          94       95    +1     
  Lines        1905     1912    +7     
=======================================
+ Hits         1870     1877    +7     
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paarals paarals linked an issue Mar 27, 2024 that may be closed by this pull request
5 tasks
@ElviaBth ElviaBth marked this pull request as ready for review April 3, 2024 08:10
Copy link
Collaborator

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job Elvia,
we need to check for the multioption responses as well.
Left you a couple of comments

@microstudi microstudi merged commit 9654679 into main Apr 29, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add voting status for participants for each question
3 participants