Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add prefixes to Redis #137

Merged
merged 3 commits into from Nov 24, 2017
Merged

fix: add prefixes to Redis #137

merged 3 commits into from Nov 24, 2017

Conversation

Atala
Copy link
Member

@Atala Atala commented Nov 10, 2017

F*x #63

I think we just need to redeploy each instance and it will be fine, as data are always polled from Postgres.

Note that I did a small trick to prefix subscribe calls.

Please don't merge I have still a question about this change

@Atala
Copy link
Member Author

Atala commented Nov 11, 2017

I don't know what happened with the fsevents dependency, is it used for something?

@alexsegura
Copy link
Member

I'll check this week.

@@ -101,7 +101,6 @@ class Cart extends React.Component
}

$.post(this.props.addToCartURL, {
date: this.props.deliveryDate,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this normal?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep (I dont remember why this change is here though)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I extracted it into a single commit 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants