Fix deepsource terraform #570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove hostNetwork config for agents (convox#549) * remove hostNetwork config for agents * Adding CodeOwners to request approve when a PR is open to merge on master * Changes CodeOwners team * update documentation Co-authored-by: Taynan Souza <taynan.tws@gmail.com> * Fix for local v3 rack install for minikube * set type of resolver-external as 'ClusterIP' only * Remove the dummy selector * Use public dns resolver to resolve the minikube ip * Add seperate domain for mac --------- Co-authored-by: Yuri Adams Chaves Maia <yuriadams@gmail.com> Co-authored-by: Taynan Souza <taynan.tws@gmail.com>
|
Hey @heronrs |
|
this issue is assigned to @yuriadams, it's up to him |
|
hey @lucasmacedot, you can fix in a single PR, thank you. |
Twsouza
force-pushed
the
staging
branch
2 times, most recently
from
053cc6a
to
73f9306
Compare
* Add support internal nginx for internal rack to rack communication * Address the doc review
) * Feat-838: Internal router for rack to communication (convox#565) * Add support internal nginx for internal rack to rack communication * Address the doc review * Change dependabot to open PRs to the staging branch (convox#573) * build(deps): bump github.com/creack/pty from 1.1.13 to 1.1.18 (convox#467) Bumps [github.com/creack/pty](https://github.com/creack/pty) from 1.1.13 to 1.1.18. - [Release notes](https://github.com/creack/pty/releases) - [Commits](creack/pty@v1.1.13...v1.1.18) --- updated-dependencies: - dependency-name: github.com/creack/pty dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/gorilla/mux from 1.7.3 to 1.8.0 Bumps [github.com/gorilla/mux](https://github.com/gorilla/mux) from 1.7.3 to 1.8.0. - [Release notes](https://github.com/gorilla/mux/releases) - [Commits](gorilla/mux@v1.7.3...v1.8.0) --- updated-dependencies: - dependency-name: github.com/gorilla/mux dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Md. Nure Alam Nahid <knightnahid@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add subnets as variables
* Change use of `aws_subnet.private` to `var.private_subnets_ids`
* Add test files
* Convert params from `map[string]string` to `map[string]interface{}`
* Revert methods.go
* Revert pkg/api changes
* Revert pkg/cli changes
* Revert pkg/console changes
* Revert pkg/structs changes
* Revert pkg/rack changes
* Add break of interfaces for terraform variables
* Fix test files
* Fix-821: Local rack fix for minikube (convox#551)
* remove hostNetwork config for agents (convox#549)
* remove hostNetwork config for agents
* Adding CodeOwners to request approve when a PR is open to merge on master
* Changes CodeOwners team
* update documentation
Co-authored-by: Taynan Souza <taynan.tws@gmail.com>
* Fix for local v3 rack install for minikube
* set type of resolver-external as 'ClusterIP' only
* Remove the dummy selector
* Use public dns resolver to resolve the minikube ip
* Add seperate domain for mac
---------
Co-authored-by: Yuri Adams Chaves Maia <yuriadams@gmail.com>
Co-authored-by: Taynan Souza <taynan.tws@gmail.com>
* Update-821: Dev rack and misc docs
* Update-821: Dev rack and misc docs-2
* Update-821: Dev rack and misc docs-3
* Revert cli changes
* Remove cli test file
* Change main subnets variable to string, add public subnets
* Fix subnets of node group
* Add gateways
* Remove nat gateway from locals
* Feat-838: Internal router for rack to communication (convox#565)
* Add support internal nginx for internal rack to rack communication
* Address the doc review
* build(deps): bump github.com/gorilla/mux from 1.7.3 to 1.8.0 (convox#575)
* Feat-838: Internal router for rack to communication (convox#565)
* Add support internal nginx for internal rack to rack communication
* Address the doc review
* Change dependabot to open PRs to the staging branch (convox#573)
* build(deps): bump github.com/creack/pty from 1.1.13 to 1.1.18 (convox#467)
Bumps [github.com/creack/pty](https://github.com/creack/pty) from 1.1.13 to 1.1.18.
- [Release notes](https://github.com/creack/pty/releases)
- [Commits](creack/pty@v1.1.13...v1.1.18)
---
updated-dependencies:
- dependency-name: github.com/creack/pty
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump github.com/gorilla/mux from 1.7.3 to 1.8.0
Bumps [github.com/gorilla/mux](https://github.com/gorilla/mux) from 1.7.3 to 1.8.0.
- [Release notes](https://github.com/gorilla/mux/releases)
- [Commits](gorilla/mux@v1.7.3...v1.8.0)
---
updated-dependencies:
- dependency-name: github.com/gorilla/mux
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Md. Nure Alam Nahid <knightnahid@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Revert changes on `pkg/cli/login.go`
* Revert changes on `pkg/rack/console.go`
* Remove comments
* Remove unecessary comment
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Md. Nure Alam Nahid <knightnahid@gmail.com>
Co-authored-by: Yuri Adams Chaves Maia <yuriadams@gmail.com>
Co-authored-by: Taynan Souza <taynan.tws@gmail.com>
Co-authored-by: Nick <nthoni@hotmail.com>
Co-authored-by: Taynan <Twsouza@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update-838: rack-to-rack docs * Update-838: rack-to-rack docs fixed
This should fix the error, the split function produced [""] if the string is empty, an array with an empty string, instead of an empty array Co-authored-by: Lucas de Macedo <122332519+lucasmacedot@users.noreply.github.com>
|
@yuriadams can you review this one? |
nightfury1204
force-pushed
the
staging
branch
2 times, most recently
from
3341718
to
6df011a
Compare
nightfury1204
force-pushed
the
staging
branch
2 times, most recently
from
9961ed6
to
1f3f912
Compare
nightfury1204
force-pushed
the
staging
branch
from
eb5223f
to
9541383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
** Describe the task and what is the goal for it. **
** Describe the bug and the solution. **
** Any additional information **
Add screenshot or video (optional)
** Any screenshot or video capture using the feature **
Does it has a breaking change?
** Describe the changes and if it has any breaking changes in any feature **
How to use/test it?
** Describe how to test or use the feature **
Checklist