Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.md #8

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

TehPeGaSuS
Copy link
Contributor

Fixed:

  • CONVOS_WEBIRC_PASSWORD_LOCALHOST not being displayed properly due to markdown malformation

Added:

  • User systemd unit file
  • Instructions how to enable user systemd without root rights and respective user commands

Fixed:
- CONVOS_WEBIRC_PASSWORD_LOCALHOST not being displayed properly due to markdown malformation

Added:
- User systemd unit file
- Instructions how to enable user systemd without root rights and respective user commands
Fixed:
- File name for logs on systemd user file
@jhthorsen jhthorsen self-requested a review March 13, 2022 01:50
@jhthorsen jhthorsen added the bug Something isn't working label Mar 13, 2022
Copy link
Contributor

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! A lot of great information here, but I do think some things needs adjustments.

For the future: It's much easier to accept a PR if it only has one change. (This PR contains bug fixes and new information)

doc/config.md Outdated Show resolved Hide resolved
doc/config.md Outdated Show resolved Hide resolved

To enable user systemd units you need to perform some extra steps, as follow:

loginctl enable-linger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to be run as root? Either way, please add an extra line break.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Does this have to be run as root?" has not been answered.

loginctl enable-linger
Then you need to create the `.config/systemd/user` folder mannually or using the following command:

systemctl --user enable systemd-tmpfiles-clean.timer && systemctl --user disable systemd-tmpfiles-clean.timer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is systemd-tmpfiles-clean? Either way, I think it's easier if you just tell the user how to create the directory manually.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still curious about what systemd-tmpfiles-clean is, and I still think it's more confusing than helpful.

doc/config.md Outdated Show resolved Hide resolved
doc/config.md Outdated Show resolved Hide resolved
@TehPeGaSuS TehPeGaSuS marked this pull request as draft March 13, 2022 08:41
- Fixed all requested reviews, hopefully
- Forgot to add $HOME to the location
doc/config.md Outdated Show resolved Hide resolved
- Add explicit commands to manually create the `$HOME/.config/systemd/user` folder
- Fixed typo
doc/config.md Outdated Show resolved Hide resolved
- Fixed identation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants