Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MongoDB driver (match with MongoJack and Jackson) #858

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

trevorgerhardt
Copy link
Member

MongoDB currently provides documentation for versions v4.3 to v4.8. When making changes, its useful to have available documentation for the driver we are using.

@trevorgerhardt trevorgerhardt added cleanup dependencies Pull requests that update a dependency file labels Jan 26, 2023
@trevorgerhardt trevorgerhardt enabled auto-merge (squash) January 26, 2023 17:46
@trevorgerhardt
Copy link
Member Author

This update must be done when the Persistence.java class is removed.

@trevorgerhardt trevorgerhardt marked this pull request as draft January 27, 2023 06:38
auto-merge was automatically disabled January 27, 2023 06:38

Pull request was converted to draft

MongoDB currently provides documentation for versions v4.3 to v4.8. When making changes, its useful to have available documentation for the driver we are using.
@abyrd abyrd changed the title Update MongoDB driver to 4.8.2 Update MongoJack, MongoDB driver, and Jackson Nov 9, 2023
update mongodb driver and jackson versions
@abyrd
Copy link
Member

abyrd commented Nov 9, 2023

I just rebased this to see how it fit with current dev, and noticed that the most recent MongoJack has a transitive dependency on 4.8.1 instead of 4.8.2, so aligned all the transitive dependencies. There seem to be some build problems though.

Looking at compilation output I realize the newer MongoDB drivers use a completely different syntax, so things like DBCursor and QueryBuilder are no longer available. Much of the database interaction would need to be rewritten and re-tested.

Originally the PR left the MongoJack version unchanged, but that would have left us with the direct mongodb-driver-sync dependency at v4.8.2 while MongoJack had a transitive dependency on a 3.x series mongodb-driver using the legacy 3.x series APIs.

Maybe the intent was to remove MongoJack along with this PR (as MongoJack might only be used in Persistence and MongoMap). I guess that leads us to a PR like #837 which would fully eliminate use of MongoJack and shift to the newer MongoDB driver API.

@abyrd abyrd changed the title Update MongoJack, MongoDB driver, and Jackson Update MongoDB driver (match with MongoJack and Jackson) Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants