Updated Microsoft.IO.RecyclableMemoryStream to version 3.0.0. #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is indeed a good idea, since version 3 has a breaking change in RecyclableMemoryStreamManager.GetStream(string) (return value has changed). alternative would be to set Version="[2.2.1,3.0.0)". |
dxdjgl
force-pushed
the
master
branch
3 times, most recently
from
7a815c9
to
7cbdc2e
Compare
trivalik
approved these changes
Feb 13, 2024
|
Hope it can merge and a build can be release soon. |
|
I have updated Microsoft.IO.RecyclableMemoryStream to version 3.0.0 and found no issues. I like the new functions in RecyclableMemoryStream. In the future, we could improve the encoder performance. |
|
@awcullen You would get a issue in case you have another library which require use of RecyclableMemoryStream with version 2, because of the breaking change mentioned above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.