Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cxl-ui): yarn upgrade-interactive --latest --scope '@vaadin' #184

Closed
wants to merge 5 commits into from

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Dec 10, 2021

@lkraav
Copy link

lkraav commented Jun 3, 2022

I think we could attempt straight to latest v23.1 RC here from https://github.com/vaadin/web-components/releases

Currently https://github.com/vaadin/web-components/releases/tag/v23.1.0-rc3

@lkraav
Copy link

lkraav commented Jun 3, 2022

After yarn upgrade-interactive struggled with yarnpkg/yarn#7734 I manually upgraded all packages.

WIP at https://github.com/web-padawan/aybolit/compare/conversionxl:master...conversionxl:leho-vaadin-upgrade?expand=1

Next step: build test for Storybook, there's no way it's going to just work, knowing some of the refactors Vaadin has done.

If you aren't already further along, you can probably rebase your work here on mine.

@anoblet
Copy link
Collaborator Author

anoblet commented Jun 3, 2022

I ran into yarnpkg/yarn#7734 as well. Deleting yarn.lock and running the command again allowed it to work.

I'll check out your branch and see what is left to be done.

@saas786
Copy link

saas786 commented Jun 7, 2022

I think we could attempt straight to latest v23.1 RC here from vaadin/web-components/releases

Currently vaadin/web-components@v23.1.0-rc3 (release)

Stable version is released: https://github.com/vaadin/web-components/releases/tag/v23.1.0

@saas786
Copy link

saas786 commented Jun 22, 2022

@anoblet closing, because of: 503f19b

@saas786 saas786 closed this Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants