Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency conventional-recommended-bump to v9 - autoclosed #959

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 16, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
conventional-recommended-bump (source) 6.1.0 -> 9.0.0 age adoption passing confidence

Release Notes

conventional-changelog/conventional-changelog (conventional-recommended-bump)

v9.0.0: conventional-recommended-bump: v9.0.0

Compare Source

⚠ BREAKING CHANGES
  • git-semver-tags,conventional-recommended-bump: gitSemverTags and conventionalRecommendedBump now return promises
  • standard-changelog: createIfMissing method now returns a promise
Features
  • git-semver-tags,conventional-recommended-bump: refactoring to use promises instead of callbacks (#​1112) (1697ecd)
  • standard-changelog: use promises (#​1111) (5015ab7)
Bug Fixes
  • conventional-changelog-conventionalcommits: fix handling input params (#​1120) (e721cde)

v8.0.0: conventional-recommended-bump: v8.0.0

Compare Source

⚠ BREAKING CHANGES
  • Node >= 16 is required
  • Now all presets are exports preset config factory function. conventional-changelog-preset-loader now exports new loadPreset and createPresetLoader functions. If you are using presets indirectly, using preset name, no any changes in configuration needed, just upgrade packages to latest versions.
Features
Bug Fixes

v7.0.1: conventional-changelog-conventionalcommits: v7.0.1

Compare Source

Bug Fixes
  • conventional-changelog-conventionalcommits: include constants.js in package (#​1095) (a730b18), closes #​1093

v7.0.0: conventional-changelog-conventionalcommits: v7.0.0

Compare Source

⚠ BREAKING CHANGES
  • Node >= 16 is required
  • Now all presets are exports preset config factory function. conventional-changelog-preset-loader now exports new loadPreset and createPresetLoader functions. If you are using presets indirectly, using preset name, no any changes in configuration needed, just upgrade packages to latest versions.
Features

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@cbou
Copy link

cbou commented Jan 28, 2024

@stevemao would be great to merge this PR :)

@stevemao
Copy link
Member

Could you please take a look why ci fails?

@TimothyJones
Copy link
Contributor

TimothyJones commented Jan 29, 2024

I'm not sure that merging this would achieve much - this package is deprecated (see here for discussion).

You could have a look at this fork that is maintained (by me) here. I'd like to update all the conventional-changelog dependencies, but I haven't had the time for a close read of the changelogs yet (the code is tightly coupled to the conventional-changelog dependencies, and some of their boundaries are exposed directly). Because the boundaries of the internal packages are exposed, I suspect that at least one breaking change is lurking in there somewhere. A PR where someone has figured out whether this is the case (and what the release notes should) be would be extremely welcome.

Anyway, CI fails because it runs on versions of node that the latest conventional-recommended-bump doesn't support.

@cbou
Copy link

cbou commented Jan 29, 2024

Thanks @TimothyJones
That's exactly how you mentioned. The CI fails because of node versions.

I was actually looking for the possibility to pass multiple paths to git-raw-commits.
I solved it by using this:

  "dependencies": {
    "standard-version": "^9.5.0"
  },
  "overrides": {
    "standard-version": {
      "git-raw-commits": "4.0.0"
    }
  },

Maybe it can help someone else...

@TimothyJones
Copy link
Contributor

Yep, that will work. I’d recommend switching to commit-and-tag-version (a drop in replacement) if you can- since it’s maintained and tested against current node versions.

@renovate renovate bot changed the title fix(deps): update dependency conventional-recommended-bump to v9 fix(deps): update dependency conventional-recommended-bump to v9 - autoclosed May 4, 2024
@renovate renovate bot closed this May 4, 2024
@renovate renovate bot deleted the renovate/conventional-recommended-bump-9.x branch May 4, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants