Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose parser and writer option overrides #896

Open
wants to merge 44 commits into
base: master
Choose a base branch
from

Conversation

s-h-a-d-o-w
Copy link

Exposing these will resolve a number of issues where people want to customize something but don't want to create a full preset to replace the default one with.

Functionally, if these overrides aren't set, their value will obviously be undefined, making this change fully backwards compatible.

Two examples about a simple sorting override:
Fixes #293
Fixes #869

wesleytodd and others added 30 commits October 2, 2020 14:01
Previously, as shown in conventional-changelog#542, using both options at the same time resulted in the bump file's version being set to null.

This was validated in the first of the new unit tests. The other unit tests simply check that the rest of the behavior is correct in this case.

With this combination the user can override the version, the purpose of `release-as`, while still starting or continuing a pre-release, the purpose of of the `prerelease`.

Fixes conventional-changelog#542
… this package starts at 9.5.0, this requirement is met)
feat(tag): add an option to force tag replacement
…ovate/actions-checkout-3.x

chore(deps): update actions/checkout action to v3
…ovate/actions-setup-node-3.x

chore(deps): update actions/setup-node action to v3
fix: Use relative path in git ignore
fix: Combining both release-as and prerelease now doesn't break package
fix: continue with commit when commitAll is true
…-version

fix: print version number that updater.writeVersion returns
…to-git-tag-version

fix: fallback to git tag if no version in package file
…ease-please--branches--master--components--commit-and-tag-version

chore(master): release 9.6.0
…novate/mocha-10.x

chore(deps): update dependency mocha to v10
@MisterTimn
Copy link

MisterTimn commented Aug 9, 2022

Since this repository has been deprecated, maybe it's an idea to target this PR to the maintained fork?
https://github.com/absolute-version/commit-and-tag-version/pulls

We need this feature as well :) if you don't feel like opening the PR I can also implement the changes but I don't want to steal your thunder ⚡

@s-h-a-d-o-w
Copy link
Author

@MisterTimn

Great to see that somebody else is continuing this project, since I used it because I wasn't happy with release-please (which is the suggested alternative here) in the first place!

It's especially nice to see that it looks like pact is at least loosely associated with it. Coincidentally, I used pact-js at a company a few years ago.

Anyway, I'll try to get this done soon. 🙂

@s-h-a-d-o-w
Copy link
Author

Plus, thanks for the opportunity to contribute myself rather than just copying my stuff, that's quite considerate. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

how to generate CHANGELOG order by time Chronological Changelog
10 participants