fix(deps): bump conventionalcommits to 4.3.1 #648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the conventional-changelog-conventionalcommits dependency to version 4.3.1 from 4.3.0 to address security vulnerabilities outlined in https://npmjs.com/advisories/1213, present in chain-dependency "dot-prop" which has since been fixed upstream.
| @@ -38,7 +38,7 @@ | |||
| "chalk": "^2.4.2", | |||
| "conventional-changelog": "3.1.21", | |||
| "conventional-changelog-config-spec": "2.1.0", | |||
| "conventional-changelog-conventionalcommits": "4.3.0", | |||
| "conventional-changelog-conventionalcommits": "4.3.1", | |||
There was a problem hiding this comment.
While we're at it, could these all be changed to ^ or at least ~ versions so that we don't have to wait for conventional-changelog releases to get simple patch fixes in our own repos?
There was a problem hiding this comment.
I would agree here, but I didn't want to make this pull request about a practice change, only a dependency update.
Seeing as this is addressed by #650 to a more up-to-date version, I closed this PR. However, I would encourage you to make an issue discussing the suggestion you've made here.
|
Closing this in favor of #650 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
conventional-changelog-conventionalcommitsdependency to version4.3.1from4.3.0to address security vulnerabilities outlined in https://npmjs.com/advisories/1213, present in chain-dependencydot-propwhich has since been fixed upstream.Closes #642