Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up group selection #741

Open
wants to merge 2 commits into
base: v5.x
Choose a base branch
from
Open

Speed up group selection #741

wants to merge 2 commits into from

Conversation

MartinSzollos2016
Copy link
Contributor

Dispatch event after all checkboxes are checked

@f3l1x
Copy link
Member

f3l1x commented Feb 24, 2019

cc @paveljanda ?

@paveljanda
Copy link
Member

I can't really see what has changed.. What has changed?

@MartinSzollos2016
Copy link
Contributor Author

Ve starém kódu (189-202) ve for cyklu se pro každy checkbox rozhoduje zda uživatele používá IE. ( Očekává se, že během selekce uživatel změní browser?) Následně se vytváří nový event, opět pro každý checkbox a ten se rovnou spouští. (řádek 201 -> následně skok na 150).
Můj kód testuje browser na začátku jen jednou.
Vytvoří jeden event, který se spustí po zatržení všech checkboxů.

@MartinSzollos2016
Copy link
Contributor Author

Asi by bylo dobré sloučit s tímto:
#740

@f3l1x
Copy link
Member

f3l1x commented Nov 24, 2021

#740 je mergnuta. Muzeme toto uzavrit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants