Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kofi Nedjoh - Frontend Assessment #86

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

koficodedat
Copy link

Assessment

Demo Video:

Kofi.Nedjoh.-.Contra.FrontEnd.Assessment.mp4

Libraries I used

  • focus-trap-react to help keep focus in currently opened Modal
  • body-scroll-lock to help lock background scroll when Modal is open

Liberties I took

  • Outside click can be configured to either dismiss the Modal or not
  • Option to make Modal fullscreen or not
  • At very small screen sizes (450px and below), modal becomes fullscreen. This is a media query addition for the demo page and is not baked into the Modal implementation itself

Improvements provided enough time

  • Styling will be migrated to a SASS model to help with encapulation and reuse.
  • Storybook will be added to provide more flexible and variable testing.
  • Proper snapshot testing will be added for varying states.
  • Extensibility will be implemented to take advantage of custom styling as well as placement of segments like header and footer. It will however remain foundational if you do not extend it.
  • Look for more ways to clean the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant